Add CaseIterable conformance for string, int enums#559
Merged
czechboy0 merged 2 commits intoApr 3, 2024
Merged
Conversation
Contributor
|
@swift-server-bot test this please |
Contributor
|
Ah let me look at that failing compat test in a separate PR, I don't believe this was caused by your PR. |
Contributor
Author
|
Yes that was strange, I was already trying to figure out why the test is failing. |
Contributor
|
@swift-server-bot test this please |
czechboy0
approved these changes
Apr 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
CaseIterable#548.Modifications
conformancesarray.Result
StringandIntgenerated enums will conform by default toCaseIterableprotocol.Test Plan
OpenAPIGeneratorReferenceTests.